fix(app): fix various install and version issues #14926
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes various ongoing issues building versions into the system. This is a follow-on to #14844 (61b1371)
define
config the way we do it does not hang the defined values off of props ofglobal
explicitly (or maybe us injecting'globalThis'
intoglobal
breaks it) so use them as true globals, altering the way they're accessed and the way they're declared in the typings.Testing
This is a bit annoying to test.
You must test this on a compiled app package. You cannot test this on a dev build.
On a compiled app package,
include
on undefined in your app logsI haven't dev-tested the second part because on my home setup making a full compiled app package is broken for some reason, and you can't actually run the node side in dev
This once more,
Closes EXEC-385
Closes RQA-2579