Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): set default selected robot on slideout to first valid robot #14925

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix(app): set default selected robot on slideout to first valid robot #14925

merged 1 commit into from
Apr 16, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Apr 16, 2024 •
edited by jira bot
Loading

closes RQA-2578

Overview

In ChooseRobotSlideout, robotBusyStatusByNameReducer does not initially return the correct busy status of each robot, resulting in setting the selected robot to the first connectable robot even if it is busy. This PR updates the useEffect resetting the default selection once the robots' busy statuses are properly retrieved.

Test Plan

  • select any protocol
  • start setup
  • observe that the selected robot defaults to the first available robot option on the slideout

Changelog

  • check that the slideout's selected robot exists in available robots after the robots' busy statuses are fully retrieved
  • reset to the first available robot if the selected robot is not available

Review requests

@mjhuff per working together

Risk assessment

low

@ncdiehl
fix(app): set selected robot on slideout to first valid robot
7c68bd1 
robotBusyStatusByNameReducer does not initially return the correct busy status of each robot,
resulting in setting the selected robot to the first connectable robot even if it is busy. This PR
updates the useEffect resetting the default selection once the robots' busy statuses are properly
retrieved.
@ncdiehl11 ncdiehl11 requested a review from mjhuff April 16, 2024 19:31
@ncdiehl11 ncdiehl11 marked this pull request as ready for review April 16, 2024 19:32
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner April 16, 2024 19:32
@ncdiehl11 ncdiehl11 changed the title fix(app): set selected robot on slideout to first valid robot fix(app): set default selected robot on slideout to first valid robot Apr 16, 2024
koji
koji approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes look good to me

mjhuff
mjhuff reviewed Apr 16, 2024
View reviewed changes
Copy link
Contributor

@mjhuff mjhuff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

@ncdiehl11 ncdiehl11 merged commit 4abe652 into edge Apr 16, 2024
26 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_app-choose-robot-slideout-selected-robot branch April 16, 2024 20:06
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
@ncdiehl11 @Carlos-fernandez
fix(app): set default selected robot on slideout to first valid robot (…
0f0b97a 
…#14925)

closes RQA-2578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjhuff mjhuff mjhuff left review comments

@koji koji koji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ncdiehl11 @koji @mjhuff @ncdiehl