Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add test workflow for opentrons-ai-client #14923

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Apr 16, 2024

Overview

add test workflow for opentrons-ai-client

solve AUTH-210 partially

[the result]
https://github.com/Opentrons/opentrons/actions/runs/8711151730/job/23894628978?pr=14924

Test Plan

Changelog

Review requests

Risk assessment

low

add test workflow for opentrons-ai-client

solve AUTH-210 partially
@koji koji marked this pull request as ready for review April 16, 2024 18:47
@koji koji requested a review from a team as a code owner April 16, 2024 18:47
@koji koji mentioned this pull request Apr 16, 2024
@koji koji marked this pull request as draft April 16, 2024 18:55
@koji koji marked this pull request as ready for review April 16, 2024 19:11
- '**'
tags:
- 'v*'
- 'ot3@*'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ot3 means flex?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes
we keep using ot3 for some configurations and tags.

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github workflows are out of my element but the check passes so thats good 😅

@koji koji merged commit e20c8e5 into edge Apr 17, 2024
4 checks passed
@koji
Copy link
Contributor Author

koji commented Apr 17, 2024

I will update this workflow later to add build and deploy workflows.

@koji koji deleted the chore_add-test-workflow-for-opentrons-ai-client branch April 17, 2024 15:22
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
* chore: add test workflow for opentrons-ai-client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants