Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opentrons-ai-client): add ChatContainer component #14921

Merged
merged 7 commits into from
Apr 18, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Apr 16, 2024

Overview

add ChatContainer component.

close AUTH-207

Test Plan

  1. make -C opentrons-ai-client dev
    go to localhost:5137 and SidePanel and ChatContainer show up

  2. make -C components dev
    ChatContainer shows up in organisms

Changelog

  • add ChatContainer component, its tests, and its stories
  • update App

Review requests

Risk assessment

low

@koji koji requested review from ncdiehl11 and jerader April 16, 2024 18:22
@koji koji marked this pull request as ready for review April 16, 2024 18:23
@koji koji requested a review from a team as a code owner April 16, 2024 18:23
@koji koji removed the request for review from a team April 16, 2024 18:23
@jerader
Copy link
Collaborator

jerader commented Apr 17, 2024

For some reason i'm not seeing chatContainer in the dev env and it also doesn't show up in storybook

Screenshot 2024-04-17 at 07 55 45 Screenshot 2024-04-17 at 07 55 57

@koji
Copy link
Contributor Author

koji commented Apr 17, 2024

For some reason i'm not seeing chatContainer in the dev env and it also doesn't show up in storybook

Screenshot 2024-04-17 at 07 55 45 Screenshot 2024-04-17 at 07 55 57

@jerader
Did you see any error in the dev tools console?
On my end, there is no issue.

@koji
Copy link
Contributor Author

koji commented Apr 17, 2024

Screenshot 2024-04-17 at 8 48 39 AM

@koji koji requested a review from jerader April 17, 2024 12:59
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! storybook and dev look as expected now too.

@koji koji merged commit 0e79a40 into edge Apr 18, 2024
6 checks passed
@koji koji deleted the feat_add-opentron-ai-client-container branch April 18, 2024 12:55
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
* feat(opentrons-ai-client): add ChatContainer component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants