fix(protocol-designer): filter out module addressable areas from newL… #14918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocation dropdown closes AUTH-348
jerader
requested review from
koji and
ncdiehl11
and removed request for
a team
jerader
commented
Apr 16, 2024
| @@ -232,7 +233,8 @@ export const getUnoccupiedLabwareLocationOptions: Selector< | |||
| .includes(slotId) && | |||
| !isTrashSlot && | |||
| !WASTE_CHUTE_ADDRESSABLE_AREAS.includes(slotId) && | |||
| !notSelectedStagingAreaAddressableAreas.includes(slotId) | |||
| !notSelectedStagingAreaAddressableAreas.includes(slotId) && | |||
There was a problem hiding this comment.
line 101 of this file has a comment to write a test for this util, i'll do so in a followup at some point :D
There was a problem hiding this comment.
here is the ticket https://opentrons.atlassian.net/browse/AUTH-349
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ocation dropdown
closes AUTH-348
Overview
When modules got added to deck config, there were a lot more addressable areas added for each module and their slot location. This PR filters them out in the new location dropdown for move labware
Test Plan
create a flex protocol. add a move labware step and move the tiprack. In the new location dropdown, only slots and off-deck should be available. the module addressable areas should not be available.
Changelog
Review requests
see test plan
Risk assessment
low