fix(protocol-designer): moveLabware newLocation error accounts for cu… #14917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stom labware closes RESC-243
jerader
requested review from
koji,
ncdiehl11 and
a team
and removed request for
a team
jerader
commented
Apr 16, 2024
Comment on lines
-14
to
-15
| // TODO(Jr, 1/16/24): look into the use case of this util since the i18n strings | ||
| // previously listed in this util were not found in any json. |
There was a problem hiding this comment.
no idea why i made this comment in january because this util is used for error handling in moveLabwareForm lol
koji
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…stom labware
closes RESC-243 and RQA-2573
Overview
Fixes bug outlined in escalations ticket, basically you couldn't move labware onto a module if its a custom labware
Test Plan
Create an ot-2 protocol and add either a gen1 or gen2 magnetic module. upload the ticket's attached custom labware and place it on the deck. Create a move labware step and move the custom labware onto the magnetic module. it should not error.
Changelog
Review requests
see test plan
Risk assessment
low