Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): factory mode desktop toggle #14911

Merged
merged 9 commits into from
Apr 16, 2024
Merged

Conversation

brenthagen
Copy link
Contributor

Overview

adds the advanced setting toggle to enable factory mode. following work will add password protection and logo upload

closes PLAT-280, PLAT-282

Screen Shot 2024-04-15 at 3 52 59 PM

Test Plan

Changelog

  • Adds factory mode desktop toggle

Review requests

check the desktop toggle with a robot/dev kit running an edge build - the ODD should restart in OEM mode

Risk assessment

low

…zation provider

implements a localization provider for the ODD app that substitutes anonymous translation values
when the "enableOEMMode" robot setting is on. pushes the localization provider further down the DOM
to be within the ODD api host provider for the robot settings request, and splits out a separate
instance for the desktop app. refactors the OnDeviceDisplayApp file a bit to avoid unnecessary
rerenders of providers - currently the entire app rerenders on every route change because of the
scroll ref. adds api client and react api client functions for robot settings get requests.

closes PLAT-265
adds the advanced setting toggle to enable factory mode. following work will add password protection
and logo upload

closes PLAT-280, PLAT-282
@brenthagen brenthagen requested a review from a team April 15, 2024 21:16
@brenthagen brenthagen requested a review from a team as a code owner April 15, 2024 21:16
@brenthagen brenthagen requested review from mjhuff and removed request for a team and mjhuff April 15, 2024 21:16
Copy link
Contributor

@b-cooper b-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌱

@brenthagen brenthagen merged commit dfb572c into edge Apr 16, 2024
20 checks passed
@brenthagen brenthagen deleted the app_factory-mode-toggle branch April 16, 2024 00:53
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
adds the desktop advanced setting toggle to enable factory mode.

closes PLAT-280, PLAT-282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants