Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): properly disable proceed button if no available robots #14907

Merged
merged 4 commits into from
Apr 15, 2024
Merged

fix(app): properly disable proceed button if no available robots #14907

merged 4 commits into from
Apr 15, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Apr 15, 2024 •
edited by jira bot
Loading

closes RQA-2517

Overview

Fixes bug where ChooseRobotSlideout rendered by ChooseRobotToRunProtocolSlideout sets the selected robot to the first connectable robot, even if there is no available robot, when all connectable robots are busy (in runs). Checks for healthy reachable AND available robots when setting the selected robot on the slideout.

Leave current behavior for slideout when called by SendProtocolToFlexSlideout, since we can still send protocols to Flexes in active runs.

Test Plan

  • limit connectable robots to one or a few (one way is to disconnect from the network and only run dev robot server)
  • begin protocol setup on all connectable robots
  • navigate to Protocols tab and open the slideout by selecting "Start setup"
  • confirm that no available robots options are shown and that the footer button is disabled
  • on the protocol details page, select "Send to Opentrons Flex" from the overflow menu
  • confirm that all connectable Flexes show, even if they are in runs
Screen.Recording.2024-04-15.at.4.20.37.PM.mov

Changelog

  • if starting protocol setup, map AvailableRobotOption to only available robots
  • fix test

Review requests

@mjhuff per working on bug fix together

Risk assessment

low

@ncdiehl
fix(app): properly disable proceed button if no connectable + availab…
a3d2a05 
…le robots

Check for healthy reachable AND available robots when setting the default robot option on the
slideout.
@ncdiehl11 ncdiehl11 self-assigned this Apr 15, 2024
@ncdiehl11 ncdiehl11 requested a review from mjhuff April 15, 2024 20:26
mjhuff
mjhuff approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@mjhuff mjhuff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits, but looks good with passing CI. Thank you for fixing this and adding tests!

app/src/organisms/ChooseRobotSlideout/index.tsx Outdated Show resolved Hide resolved
app/src/organisms/ChooseRobotSlideout/index.tsx Outdated Show resolved Hide resolved
@ncdiehl11 ncdiehl11 marked this pull request as ready for review April 15, 2024 21:33
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner April 15, 2024 21:33
@ncdiehl11 ncdiehl11 requested review from brenthagen and removed request for a team April 15, 2024 21:33
@ncdiehl11 ncdiehl11 merged commit 8cc2fc7 into edge Apr 15, 2024
20 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_app-choose-robot-slideout branch April 15, 2024 21:33
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
@ncdiehl11 @Carlos-fernandez
fix(app): properly disable proceed button if no available robots (#14907
5e2fe28 
)

closes RQA-2517
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjhuff mjhuff mjhuff approved these changes

@brenthagen brenthagen Awaiting requested review from brenthagen brenthagen is a code owner automatically assigned from Opentrons/js

Assignees

@ncdiehl11 ncdiehl11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ncdiehl11 @mjhuff @ncdiehl