feat(app): push recent RTP run card click to protocol details #14906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etup Because we don't yet have designs displaying details of a recent protocol run card with specific runtime parameter values, we want to allow the user to reset parameter values afer clicking a recent run card for an RTP-containing protocol. Behavior for non-RTP protocols will not change and will push the user directly to protocol run setup.
jerader
reviewed
Apr 15, 2024
app/src/organisms/OnDeviceDisplay/RobotDashboard/RecentRunProtocolCard.tsx
Outdated
Show resolved
Hide resolved
jerader
reviewed
Apr 15, 2024
app/src/organisms/OnDeviceDisplay/RobotDashboard/__tests__/RecentRunProtocolCard.test.tsx
Outdated
Show resolved
Hide resolved
jerader
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Because we don't yet have designs displaying details of a recent protocol run card with specific runtime parameter values, we want to allow the user to reset parameter values afer clicking a recent run card for an RTP-containing protocol. Behavior for non-RTP protocols will not change and will push the user directly to protocol run setup.
In the future, ideally, we can communicate RTP overrides on the recent run card and produce unique cards for different parameter selections on the same protocol ID. In this way, we can clone the run and avoid having to re-select parameters.
Test Plan
Screen.Recording.2024-04-15.at.3.28.26.PM.mov
Changelog
Review requests
auth
Risk assessment
medium