refactor(robot-server): Delete unused models for maintenance runs, and document actions list as empty
#14905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
approved these changes
Apr 15, 2024
SyntaxColoring
changed the title
actions list as empty.actions list as empty.
SyntaxColoring
changed the title
actions list as empty.actions list as empty
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
…d document `actions` list as empty (#14905)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Maintenance runs have an
actionsfield, like non-maintenance runs. Unlike non-maintenance runs, though, it's currently impossible for it to contain anything in practice. There is noPOST /maintenance_runs/{run_id}/actionsendpoint the way there isPOST /runs/{run_id/actions.This PR deletes some unused code that was supporting actions on maintenance runs, and documents the
actionsfield as always being empty. Same deal as #14670, but for Python instead of TypeScript.This is while I'm in the area for EXEC-382, trying to answer questions like "what are the different ways for a maintenance run to end."
Test Plan
Review requests
None in particular.
Risk assessment
No risk.