refactor(protocol-designer): export modal to require app 7.3.0 or higher #14890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
requested review from
TamarZanzouri,
koji and
ncdiehl11
and removed request for
a team and
TamarZanzouri
koji
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AUTH-340
Overview
Basically, as outlined in the ticket, in the past we have generally always required users to update their robot to the latest version that is out at the time of PD's release mainly because there are usually new features in the app that PD depends upon. This time, there are no new features in the app 7.3.0 that PD depends upon. But we want to require 7.3.0 to minimize the app builds that QA needs to test on.
Test Plan
in PD, type
localStorage.clear()in console and refresh, you should see the announcement modal. Make sure it says app 7.3.0 is required. Make a protocol and export and see that the export modal says that app 7.3.0 is required.Changelog
Review requests
see test plan
Risk assessment
low