Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): anonymize all app strings #14884

Merged
merged 4 commits into from
Apr 12, 2024
Merged

refactor(app): anonymize all app strings #14884

merged 4 commits into from
Apr 12, 2024

Conversation

ecormany
Copy link
Contributor

@ecormany ecormany commented Apr 11, 2024

Overview

Fully anonymize all localization strings and finalize copy.

Addresses PLAT-243

Test Plan

None. Unit tests to come later.

Changelog

  • Removed nearly all mentions of "Opentrons" in strings. (Only one left is for OT-2 tip length calibration.)
  • Some very light edits elsewhere, also updated in "branded" strings.

Risk assessment

minor, but it's not trivial to QA all of these changes in situ

Base automatically changed from app_odd-anonymous-localization-provider to edge April 12, 2024 19:31
Copy link
Contributor

@brenthagen brenthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ecormany ecormany marked this pull request as ready for review April 12, 2024 20:15
@ecormany ecormany requested a review from a team as a code owner April 12, 2024 20:15
@ecormany ecormany merged commit 3142bc2 into edge Apr 12, 2024
20 checks passed
@ecormany ecormany deleted the copy-oem-anon branch April 12, 2024 21:31
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
# Overview

Fully anonymize all localization strings and finalize copy.

Addresses PLAT-243

# Test Plan

None. Unit tests to come later.

# Changelog

- Removed nearly all mentions of "Opentrons" in strings. (Only one left
is for OT-2 tip length calibration.)
- Some very light edits elsewhere, also updated in "branded" strings.

# Risk assessment

minor, but it's not trivial to QA all of these changes in situ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants