Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(protocol-engine): Rename stop() and pause() -> request_stop() and request_pause() #14879

Merged
merged 3 commits into from
Apr 12, 2024
Merged

refactor(protocol-engine): Rename stop() and pause() -> request_stop() and request_pause() #14879

merged 3 commits into from
Apr 12, 2024

Commits on Apr 11, 2024

  1. Rename stop() -> stop_soon(). 

    This is to reflect the apparent reality of what this method is doing.
    @SyntaxColoring
    SyntaxColoring committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    fb9b46e View commit details
    Browse the repository at this point in the history

  2. stop_soon() -> request_stop().

    @SyntaxColoring
    SyntaxColoring committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    3717cf9 View commit details
    Browse the repository at this point in the history

  3. pause() -> request_pause().

    @SyntaxColoring
    SyntaxColoring committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    726931f View commit details
    Browse the repository at this point in the history