fix(protocol-designer, components): discarding vs delete step form button text #14872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
requested review from
ncdiehl11 and
koji
and removed request for
a team
jerader
changed the title
koji
reviewed
Apr 11, 2024
components/src/lists/TitledList.tsx
Outdated
| @@ -98,6 +101,15 @@ export function TitledList(props: TitledListProps): JSX.Element { | |||
| iconProps && iconProps.className | |||
| ) | |||
|
|
|||
| let textColor = 'auto' | |||
There was a problem hiding this comment.
need to set auto instead of '' or undefined?
koji
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AUTH-319
Overview
@koji noticed this bug initially where if you delete a step via the close modal for a form, it was different from deleting a step from the delete button in the form. Upon investigating, the actions were actually correct so I modified the button text to be more clear. When closing from the close modal, you are basically discarding of an unsaved step. So you aren't deleting anything, you are just closing/discarding of it.
Additionally, the
started deck stateandfinal deck statenow is highlighted again when it is active (along with the active color in the liquids tab and app in the settings tab), to match legacy behavior that was broken starting in PD 6.0.0 (see that it is not broken here: https://sandbox.designer.opentrons.com/[email protected]/)Test Plan
Create a flex or ot-2 protocol. Go to deck map and see that the starting deck state is blue. Add a step and before saving it, delete it via the the "delete step" button and see that it navigates you to the starting deck state. Now create a new step and delete it via the "cancel" button and see that it just discards of the step and does not navigate you to the starting deck state.
Changelog
Review requests
see test plan
Risk assessment
low