feat(protocol-designer): export and announcement modal for PD 8.1 #14870

jerader · 2024-04-11T16:04:58Z

Overview

Add announcement and update export modal. App version 7.2.0 or higher is needed in order to match the pipette collision warnings that were introduced in App 7.2

Test Plan

check the 2 modals -> first opening PD and then exporting a protocol

Changelog

add new announcement and text
update export modal
add test coverage for blocking hint

Review requests

see test plan

Risk assessment

low

closes AUTH-8 AUTH-9

jerader · 2024-04-11T16:05:39Z

protocol-designer/src/components/modals/AnnouncementModal/announcements.tsx

+ {
+ announcementKey: 'customParamsAndMultiTipAndModule8.1',
+ image: (
+ // TODO(jr, 4/11/24): add image to announcement modal


i actually don't know if we need/want an image here so i'll revisit it later when Felix has signed off on PD 8.1

Lots of text, and no obvious associated visual. Skipping seems fine to me.

jerader · 2024-04-11T16:06:47Z

protocol-designer/src/localization/en/modal.json

+ "body1": "Introducing the {{pd}} 8.1. Starting today, you will be able to:",
+ "body2": "Customize blowout flowRate speed and height",
+ "body3": "Customize aspirate, dispense, and mix <i>'x'</i> and <i>'y'</i> well positioning",
+ "body4": "Assign up to 3 types of tipracks to a single pipette",
+ "body5": "For the Flex only; add up to 7 Temperature Modules on the deck at the same time",
+ "body6": "All protocols require {{app}} version <strong> 7.2+ </strong> to run."


can you review the copy here when you have a minute @ecormany?

Suggested change

"body1": "Introducing the {{pd}} 8.1. Starting today, you will be able to:",

"body2": "Customize blowout flowRate speed and height",

"body3": "Customize aspirate, dispense, and mix 'x' and 'y' well positioning",

"body4": "Assign up to 3 types of tipracks to a single pipette",

"body5": "For the Flex only; add up to 7 Temperature Modules on the deck at the same time",

"body6": "All protocols require {{app}} version 7.2+ to run."

"body1": "Introducing {{pd}} 8.1. Starting today, you will be able to:",

"body2": "Customize blowout speed and height.",

"body3": "Adjust horizontal position within a well when aspirating, dispensing, or mixing.",

"body4": "Assign up to three types of tip racks to a single pipette.",

"body5": "Add multiple Temperature Modules to the deck (Flex only).",

"body6": "All protocols require {{app}} version 7.2.0 or later to run."

Double-check me: is it 7.2.0 for the required robot software?

There are pipette collision logic updates that were added in App 7.2.0 that will be mirrored in PD 8.1. Otherwise, all the added functionality in this release has been supported in App prior to App 7.2.0

koji · 2024-04-11T16:27:51Z

The changes look good to me.

One quick question about the first modal.
I see the scrollbar space in the first modal but your screenshot doesn't have it. Because of screenshot's area?

jerader · 2024-04-11T17:16:08Z

One quick question about the first modal. I see the scrollbar space in the first modal but your screenshot doesn't have it. Because of screenshot's area?

@koji , oh wow good catch. i did not see a scrollbar from my end! i can add a css prop to make sure the scrollbar is always invisible.

jerader · 2024-04-11T17:33:30Z

One quick question about the first modal. I see the scrollbar space in the first modal but your screenshot doesn't have it. Because of screenshot's area?

@koji , oh wow good catch. i did not see a scrollbar from my end! i can add a css prop to make sure the scrollbar is always invisible.

@koji i decided not to mess with the css since its using the legacy Modal component that a handful of stuff still uses. i'll leave the scrollbar visible for now. Hopefully we can make everything look much nicer for PD 8.2 since it'll include the redesign 🤞

koji · 2024-04-11T17:41:13Z

One quick question about the first modal. I see the scrollbar space in the first modal but your screenshot doesn't have it. Because of screenshot's area?

@koji , oh wow good catch. i did not see a scrollbar from my end! i can add a css prop to make sure the scrollbar is always invisible.

@koji i decided not to mess with the css since its using the legacy Modal component that a handful of stuff still uses. i'll leave the scrollbar visible for now. Hopefully we can make everything look much nicer for PD 8.2 since it'll include the redesign 🤞

that makes sense. At least changes look good to me.
Once this PR gets feedback from Ed, it's good to go.

koji

lgtm

koji · 2024-04-11T17:43:14Z

@jerader could you take a look into e2e test?

jerader · 2024-04-11T17:44:43Z

@jerader could you take a look into e2e test?

@koji oops ya, its because the announcement modal text changed. i'll fix it

ecormany

Left some copy suggestions. This looks like an exciting release! 🚀

ecormany · 2024-04-11T18:06:23Z

protocol-designer/src/components/modals/AnnouncementModal/announcements.tsx

+ {
+ announcementKey: 'customParamsAndMultiTipAndModule8.1',
+ image: (
+ // TODO(jr, 4/11/24): add image to announcement modal


Lots of text, and no obvious associated visual. Skipping seems fine to me.

ecormany · 2024-04-11T18:10:07Z

protocol-designer/src/localization/en/modal.json

+ "body1": "Introducing the {{pd}} 8.1. Starting today, you will be able to:",
+ "body2": "Customize blowout flowRate speed and height",
+ "body3": "Customize aspirate, dispense, and mix <i>'x'</i> and <i>'y'</i> well positioning",
+ "body4": "Assign up to 3 types of tipracks to a single pipette",
+ "body5": "For the Flex only; add up to 7 Temperature Modules on the deck at the same time",
+ "body6": "All protocols require {{app}} version <strong> 7.2+ </strong> to run."


Suggested change

"body1": "Introducing the {{pd}} 8.1. Starting today, you will be able to:",

"body2": "Customize blowout flowRate speed and height",

"body3": "Customize aspirate, dispense, and mix 'x' and 'y' well positioning",

"body4": "Assign up to 3 types of tipracks to a single pipette",

"body5": "For the Flex only; add up to 7 Temperature Modules on the deck at the same time",

"body6": "All protocols require {{app}} version 7.2+ to run."

"body1": "Introducing {{pd}} 8.1. Starting today, you will be able to:",

"body2": "Customize blowout speed and height.",

"body3": "Adjust horizontal position within a well when aspirating, dispensing, or mixing.",

"body4": "Assign up to three types of tip racks to a single pipette.",

"body5": "Add multiple Temperature Modules to the deck (Flex only).",

"body6": "All protocols require {{app}} version 7.2.0 or later to run."

Double-check me: is it 7.2.0 for the required robot software?

…4870) closes AUTH-8 AUTH-9

jerader added 3 commits April 11, 2024 10:30

add announcement key

2e54bb5

add export modal info

2d42675

feat(protocol-designer): export and announcement modal for PD 8.1

7a4ad03

closes AUTH-8 AUTH-9

jerader requested a review from a team as a code owner April 11, 2024 16:04

jerader commented Apr 11, 2024

View reviewed changes

jerader requested review from koji and ncdiehl11 and removed request for a team April 11, 2024 16:08

koji requested a review from ecormany April 11, 2024 16:28

koji approved these changes Apr 11, 2024

View reviewed changes

fix cypress

1dfd421

jerader requested a review from a team as a code owner April 11, 2024 17:54

jerader removed the request for review from a team April 11, 2024 18:01

ecormany reviewed Apr 11, 2024

View reviewed changes

update copy

22e4688

jerader merged commit fa6066f into edge Apr 11, 2024
14 checks passed

jerader deleted the pd_announcement-modal-8.1 branch April 11, 2024 18:34

Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024

feat(protocol-designer): export and announcement modal for PD 8.1 (#1…

5969715

…4870) closes AUTH-8 AUTH-9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(protocol-designer): export and announcement modal for PD 8.1 #14870

feat(protocol-designer): export and announcement modal for PD 8.1 #14870

jerader commented Apr 11, 2024

jerader Apr 11, 2024 •

edited

Loading

ecormany Apr 11, 2024

jerader Apr 11, 2024

ecormany Apr 11, 2024

jerader Apr 11, 2024

koji commented Apr 11, 2024 •

edited

Loading

jerader commented Apr 11, 2024

jerader commented Apr 11, 2024

koji commented Apr 11, 2024 •

edited

Loading

koji left a comment

koji commented Apr 11, 2024

jerader commented Apr 11, 2024

ecormany left a comment

ecormany Apr 11, 2024

ecormany Apr 11, 2024

feat(protocol-designer): export and announcement modal for PD 8.1 #14870

feat(protocol-designer): export and announcement modal for PD 8.1 #14870

Conversation

jerader commented Apr 11, 2024

Overview

Test Plan

Changelog

Review requests

Risk assessment

jerader Apr 11, 2024 • edited Loading

Choose a reason for hiding this comment

ecormany Apr 11, 2024

Choose a reason for hiding this comment

jerader Apr 11, 2024

Choose a reason for hiding this comment

ecormany Apr 11, 2024

Choose a reason for hiding this comment

jerader Apr 11, 2024

Choose a reason for hiding this comment

koji commented Apr 11, 2024 • edited Loading

jerader commented Apr 11, 2024

jerader commented Apr 11, 2024

koji commented Apr 11, 2024 • edited Loading

koji left a comment

Choose a reason for hiding this comment

koji commented Apr 11, 2024

jerader commented Apr 11, 2024

ecormany left a comment

Choose a reason for hiding this comment

ecormany Apr 11, 2024

Choose a reason for hiding this comment

ecormany Apr 11, 2024

Choose a reason for hiding this comment

jerader Apr 11, 2024 •

edited

Loading

koji commented Apr 11, 2024 •

edited

Loading

koji commented Apr 11, 2024 •

edited

Loading