Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): orchestration component for new quick transfer flow #14808

Merged
merged 8 commits into from
Apr 15, 2024

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Apr 4, 2024

fix PLAT-173, PLAT-228, PLAT-271

Overview

This PR sets up the orchestration component, text file, and state for the new quick transfer flow and adds the first "create new transfer" screen

Test Plan

  1. With the Quick Transfer FF on, navigate to the protocols tab and click the "+ quick transfer" button
  2. Add Using the back, continue, and exit buttons, go through the various screens in this wizard
  3. Currently only titles are implemented after the first page, continue button and back button move through the wizard, exit takes you back to the protocols page
    https://github.com/Opentrons/opentrons/assets/14302493/1288eb55-8b63-440d-9eb5-025f48729883
    Screen Shot 2024-04-12 at 4 26 54 PM

Changelog

  1. Add new translation file for quick transfer, add title copy
  2. Create orchestration component and setup the 8 steps
  3. Add TS type and functions for useReducer storage that we'll use to manage the output of this wizard
  4. Make a few tweaks to the ChildNavigation ODD header to allow for designed functionality
  5. Adjusted DeckConfigurator to allow for static fixtures in the center column

Review requests

Look through the orchestration component and reducer types

Risk assessment

Low, behind FF

@smb2268 smb2268 self-assigned this Apr 4, 2024
@smb2268 smb2268 requested a review from a team as a code owner April 4, 2024 20:05
@smb2268 smb2268 changed the title feat(app): orchestration component for new quick transfer flowx feat(app): orchestration component for new quick transfer flow Apr 4, 2024
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the quick transfer flow follow the general pattern we use for other flows, ie

organisims/QuickTransferFlows and then rename NewTransferWizard.tsx to index.tsx?

@smb2268 smb2268 requested a review from jerader April 12, 2024 18:35
 Please enter the commit message for your changes. Lines starting
@@ -72,4 +72,26 @@ describe('ChildNavigation', () => {
fireEvent.click(secondaryButton)
expect(mockOnClickSecondaryButton).toHaveBeenCalled()
})
it.fails(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow i didn't know it.fails was a thing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't either!! found it in the docs looking for a way to test this use case

Copy link
Contributor

@b-cooper b-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@smb2268 smb2268 merged commit 5b84b34 into edge Apr 15, 2024
33 checks passed
@smb2268 smb2268 deleted the app_new-transfer-wizard branch April 15, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants