-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): orchestration component for new quick transfer flow #14808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the quick transfer flow follow the general pattern we use for other flows, ie
organisims/QuickTransferFlows
and then rename NewTransferWizard.tsx
to index.tsx
?
6a51ede
to
2ee68fa
Compare
Please enter the commit message for your changes. Lines starting
@@ -72,4 +72,26 @@ describe('ChildNavigation', () => { | |||
fireEvent.click(secondaryButton) | |||
expect(mockOnClickSecondaryButton).toHaveBeenCalled() | |||
}) | |||
it.fails( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow i didn't know it.fails
was a thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't either!! found it in the docs looking for a way to test this use case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
fix PLAT-173, PLAT-228, PLAT-271
Overview
This PR sets up the orchestration component, text file, and state for the new quick transfer flow and adds the first "create new transfer" screen
Test Plan
https://github.com/Opentrons/opentrons/assets/14302493/1288eb55-8b63-440d-9eb5-025f48729883
Changelog
Review requests
Look through the orchestration component and reducer types
Risk assessment
Low, behind FF