Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create performance metrics project #14806

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

DerekMaggio
Copy link
Contributor

@DerekMaggio DerekMaggio commented Apr 4, 2024

Overview

Basic setup of Performance Metrics project

Closes https://opentrons.atlassian.net/browse/EXEC-380

Test Plan

  • Verify all makefile commands can run successfully (GH Actions will be in another PR)
  • Build wheel, install, and verify it runs

@DerekMaggio DerekMaggio requested a review from a team as a code owner April 4, 2024 19:14
@DerekMaggio DerekMaggio requested a review from a team April 4, 2024 19:14
@DerekMaggio DerekMaggio self-assigned this Apr 4, 2024
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the tooling we use in monorepo python projects consistent, with flake8, mypy, black, and so on at the same versions as the other projects. This eases everybody's ability to context switch.

@DerekMaggio DerekMaggio requested review from sfoster1 and a team April 5, 2024 13:20
@@ -0,0 +1,13 @@
[tool.ruff]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove this one too - we're still using setup.py

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

71cb584 should fix it

@DerekMaggio DerekMaggio marked this pull request as draft April 5, 2024 14:52
formatting

chore: formatting and configs

chore: remove comment add more cleaning

fix data
@DerekMaggio DerekMaggio marked this pull request as ready for review April 5, 2024 15:00
@DerekMaggio DerekMaggio requested a review from a team as a code owner April 5, 2024 15:00
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@DerekMaggio DerekMaggio merged commit 3382ae3 into edge Apr 8, 2024
5 checks passed
@DerekMaggio DerekMaggio deleted the EXEC-380-create-performance-metrics-project branch April 12, 2024 14:59
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
# Overview

Basic setup of Performance Metrics project

Closes https://opentrons.atlassian.net/browse/EXEC-380

# Test Plan

- [x] Verify all makefile commands can run successfully (GH Actions will
be in another PR)
- [x] Build wheel, install, and verify it runs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants