Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix capitalization of ML to uL in instrument cards #14779

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Apr 2, 2024

Overview

Using textTransformCapitalize was causing the uL of pipette names to convert to ML in Flex Instrument Card. This PR restores the previous, intended behavior:
Screen Shot 2024-04-02 at 12 37 44 PM

Test Plan

Look at device details page for a Flex and see that pipette names no longer have ML

Changelog

Remove textTransformCapitalize from instrument card name and add capitalization directly to the passed in text where needed

Review requests

Quick code check

Risk assessment

Low

@smb2268 smb2268 requested a review from b-cooper April 2, 2024 16:41
@smb2268 smb2268 self-assigned this Apr 2, 2024
@smb2268 smb2268 requested a review from a team as a code owner April 2, 2024 16:41
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smb2268 smb2268 merged commit 6933c61 into edge Apr 2, 2024
20 checks passed
@smb2268 smb2268 deleted the app_fix-ul-capitalization branch April 2, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants