Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(robot-server): Update status bar to account for awaiting-recovery run state #14773

Merged
merged 1 commit into from
Apr 2, 2024
Merged

fix(robot-server): Update status bar to account for awaiting-recovery run state #14773

merged 1 commit into from
Apr 2, 2024

Conversation

SyntaxColoring
Copy link
Contributor

@SyntaxColoring SyntaxColoring commented Apr 1, 2024 •
edited
Loading

Overview

Closes EXEC-363.

Test Plan

  • Run a protocol with error recovery and make sure the status bar responds appropriately.

Changelog

  • Account for EngineStatus.AWAITING_RECOVERY in the light bar task.
  • Convert the dict lookup to a match statement. This is probably slightly slower, but more type-safe, and just as concise.

Review requests

None in particular.

Risk assessment

Low.

@SyntaxColoring SyntaxColoring requested a review from a team as a code owner April 1, 2024 20:53
@SyntaxColoring SyntaxColoring changed the title feat(robot-server): Update status bar to account for awaiting-recovery run state fix(robot-server): Update status bar to account for awaiting-recovery run state Apr 1, 2024
@SyntaxColoring SyntaxColoring added fix PR fixes a bug robot server Affects the `robot-server` project labels Apr 1, 2024
DerekMaggio
DerekMaggio approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@DerekMaggio DerekMaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like the use of the match

@SyntaxColoring SyntaxColoring merged commit 2ec93cd into edge Apr 2, 2024
21 checks passed
@SyntaxColoring SyntaxColoring deleted the recovery_status_bar branch April 2, 2024 13:15
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
@SyntaxColoring @Carlos-fernandez
fix(robot-server): Update status bar to account for `awaiting-recover…
0c52a87 
…y` run state (#14773)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerekMaggio DerekMaggio DerekMaggio approved these changes

Assignees
No one assigned
Labels
fix PR fixes a bug robot server Affects the `robot-server` project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SyntaxColoring @DerekMaggio