API: adds support for pipette versions v1.3 #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andySigler
force-pushed
the
api-pipette-v2
branch
from
77f248f
to
34b5612
Compare
andySigler
force-pushed
the
api-pipette-v2
branch
from
373748b
to
114b986
Compare
andySigler
force-pushed
the
api-pipette-v2
branch
from
114b986
to
96429fb
Compare
andySigler
changed the title
|
changed model string to |
andySigler
force-pushed
the
api-pipette-v2
branch
from
7c985ab
to
894ad58
Compare
…ns from QC testing
btmorr
reviewed
Jun 4, 2018
| @@ -14,6 +14,7 @@ | |||
| class PipetteTest(unittest.TestCase): | |||
| def setUp(self): | |||
| self.robot = Robot() | |||
| self.robot.reset() | |||
There was a problem hiding this comment.
Not sure this does anything, but doesn't specifically need to be removed either
btmorr
suggested changes
Jun 4, 2018
| @@ -74,17 +76,18 @@ def test_deprecated_axis_call(self): | |||
| warnings.filterwarnings('error') | |||
| # Check that user warning occurs when axis is called | |||
| self.assertRaises( | |||
| UserWarning, Pipette, self.robot, axis='a') | |||
| RuntimeError, Pipette, self.robot, mount='left') | |||
There was a problem hiding this comment.
This doesn't keep the intended effect of this test--the original purpose was to make sure that a warning would be raised if a protocol uses a deprecated parameter
| @@ -133,8 +136,6 @@ def test_volume_percentage(self): | |||
| self.assertRaises(RuntimeError, self.p200._volume_percentage, 300) | |||
| self.assertEquals(self.p200._volume_percentage(100), 0.5) | |||
| self.assertEquals(len(self.robot.get_warnings()), 0) | |||
| self.p200._volume_percentage(self.p200.min_volume / 2) | |||
| self.assertEquals(len(self.robot.get_warnings()), 1) | |||
There was a problem hiding this comment.
Are we purposefully dropping this behavior?
andySigler
force-pushed
the
api-pipette-v2
branch
from
a8d6cb5
to
2d806c5
Compare
btmorr
approved these changes
Jun 4, 2018
|
🦅 |
|
Merging this PR broke pipette swap in the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
This PR adds API support for pipettes marked with a version number
"v1.3". This new version number is needed for pipettes that are assembled with an updated homing PCB which shifts all the plunger positions by 1.5mm.Changes include:
InstrumentWrapper, the pipette model version is derived from what pipette version is currently attached to that mount on the bot.tools.write_pipette_memoryscript to write new version strings