Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shared-data): Add definition for 96ch v3.6 with 3.0mm backlash #14721

Merged

Conversation

andySigler
Copy link
Contributor

@andySigler andySigler commented Mar 25, 2024

Overview

Increased backlash compensation improves low-volume performance.

NOTE: accuracy functions are copied over from v3.5 definition, will add new v3.6 functions in a follow-up PR estimated to be ready around April 3-8 when the data is ready

Test Plan

Changelog

Review requests

Risk assessment

@andySigler andySigler marked this pull request as ready for review March 28, 2024 13:09
@andySigler andySigler requested a review from a team as a code owner March 28, 2024 13:09
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.56%. Comparing base (583dcf6) to head (6f64526).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-7.2.2   #14721   +/-   ##
====================================================
  Coverage                67.56%   67.56%           
====================================================
  Files                     2521     2521           
  Lines                    72251    72251           
  Branches                  9311     9311           
====================================================
  Hits                     48815    48815           
  Misses                   21240    21240           
  Partials                  2196     2196           
Flag Coverage Δ
app 63.89% <ø> (ø)
protocol-designer 37.93% <ø> (ø)
shared-data 75.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sfoster1 sfoster1 changed the base branch from edge to chore_release-7.2.2 March 28, 2024 15:05
@sfoster1 sfoster1 requested review from a team as code owners March 28, 2024 15:05
@sfoster1 sfoster1 requested a review from a team March 28, 2024 15:05
@sfoster1 sfoster1 requested a review from a team as a code owner March 28, 2024 15:05
@sfoster1 sfoster1 requested review from koji and removed request for a team March 28, 2024 15:05
@sfoster1 sfoster1 force-pushed the chore-shared-data-pipette-v36-backlash-3mm branch from 1bc4863 to 6ce36f5 Compare March 28, 2024 15:06
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

This reverts commit 6ce36f5.

On the release, we're on the old schema.
@sfoster1 sfoster1 merged commit 71ae62e into chore_release-7.2.2 Mar 28, 2024
48 checks passed
sfoster1 pushed a commit that referenced this pull request Mar 28, 2024
# Overview

7.2.2 hotfix release notes.

# Changelog

- Describes #14721 
- No others so far

# Review requests

Anything else of note going into this release?

# Risk assessment

nil
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants