Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hardware): add hepa uv current to HepaUVStateResponse #14710

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Mar 21, 2024

Overview

We need to parse the new uv_current_ma value that the Hepa/UV sends in this Opentrons/ot3-firmware#762 pull request.

Closes: PLAT-16

Test Plan

  • Make sure that the new firmware sends the correct current when the UV light is on/off

Changelog

  • Add a new uv_current_ma field to the HepaUVStateResponse CAN message

Review requests

Risk assessment

Low, unreleased

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.19%. Comparing base (d0d17d7) to head (f1c3259).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #14710   +/-   ##
=======================================
  Coverage   67.19%   67.19%           
=======================================
  Files        2495     2495           
  Lines       71520    71522    +2     
  Branches     9020     9020           
=======================================
+ Hits        48056    48058    +2     
  Misses      21342    21342           
  Partials     2122     2122           
Flag Coverage Δ
hardware 55.57% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ns_hardware/firmware_bindings/messages/payloads.py 96.01% <100.00%> (+0.01%) ⬆️
...rons_hardware/hardware_control/hepa_uv_settings.py 93.93% <100.00%> (+0.09%) ⬆️

@vegano1 vegano1 changed the title feat(hardware): add hepa uv voltage value to HepaUVStateResponse feat(hardware): add hepa uv current to HepaUVStateResponse Mar 27, 2024
@vegano1 vegano1 marked this pull request as ready for review March 27, 2024 20:17
@vegano1 vegano1 requested a review from a team as a code owner March 27, 2024 20:17
@vegano1 vegano1 requested review from ahiuchingau and a team March 27, 2024 20:18
Copy link
Contributor

@ahiuchingau ahiuchingau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep yep!

@vegano1 vegano1 merged commit c981105 into edge Mar 28, 2024
25 checks passed
@vegano1 vegano1 deleted the PLAT-16_add-current-sensing branch March 28, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants