Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(robot-server): Utilize unsubscribe flags for dynamic topics #14620

Merged
merged 13 commits into from
Mar 12, 2024
Merged

refactor(robot-server): Utilize unsubscribe flags for dynamic topics #14620

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2108efa
fix notifyrefetchbody syntax
mjhuff Mar 2, 2024
4044db8
refactor(robot-server): send unsubscribe flags from dynamic topics
mjhuff Mar 2, 2024
177f47d
refactor(robot-server): add the should_unsubscribe flag for /runs/:ru…
mjhuff Mar 2, 2024
be7774b
update docstring
mjhuff Mar 2, 2024
64615d7
move poll clean up logic to the cancelled exception
mjhuff Mar 11, 2024
d153668
add generic error logging to polling breaking
mjhuff Mar 11, 2024
bff6d11
update unsubscribe response
mjhuff Mar 11, 2024
6bba0ce
separate publish logic into refetch or unsubscribe
mjhuff Mar 11, 2024
dc24831
make poll interval tunable
mjhuff Mar 11, 2024
d04968e
break out the poll function
mjhuff Mar 11, 2024
b7f1835
naming
mjhuff Mar 11, 2024
f115d40
lint
mjhuff Mar 11, 2024
557149f
test updates
mjhuff Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make poll interval tunable
  • Loading branch information
@mjhuff
mjhuff committed Mar 11, 2024
commit dc24831c63d1b25c6e48d14f9a160d16b3fb4376
4 changes: 3 additions & 1 deletion robot-server/robot_server/service/notifications/publishers/runs_publisher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@

log: logging.Logger = logging.getLogger(__name__)

POLL_INTERVAL = 1


class RunsPublisher:
"""Publishes protocol runs topics."""
Expand Down Expand Up @@ -111,7 +113,7 @@ async def _poll_engine_store(
if self._previous_state_summary_status != current_state_summary_status:
await self._publish_runs_async(run_id=run_id)
self._previous_state_summary_status = current_state_summary_status
await asyncio.sleep(1)
await asyncio.sleep(POLL_INTERVAL)
except asyncio.CancelledError:
self._clean_up_poller()
await self._publish_runs_advise_unsubscribe_async(run_id=run_id)
Expand Down