Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate Analyses Snapshot Update edge #14586

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Evaluate Analyses Snapshot Update edge #14586

merged 1 commit into from
Mar 20, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 2, 2024

This PR is an automated snapshot update request. Please review the changes and merge if they are acceptable or find you bug and fix it.

@github-actions github-actions bot requested a review from a team as a code owner March 2, 2024 07:33
@SyntaxColoring
Copy link
Contributor

Hmm, the alternateDropLocation thing looks questionable?

@SyntaxColoring
Copy link
Contributor

SyntaxColoring commented Mar 4, 2024 •
edited
Loading

We think the alternateDropLocation thing is from #14560. A known limitation of that PR at the time was that it wasn't gated behind an apiLevel bump or anything. I think we should probably just resolve that limitation so we can go back to trusting these tests, and so we don't forget about it for the next release.

@github-actions github-actions bot force-pushed the app-testing/edge-from-edge branch 4 times, most recently from 1188dc5 to 482451a Compare March 9, 2024 07:34
@github-actions github-actions bot force-pushed the app-testing/edge-from-edge branch 5 times, most recently from 6933611 to 172d6de Compare March 16, 2024 07:34
y3rsh
y3rsh reviewed Mar 16, 2024
View reviewed changes
...t_test/test_analysis_snapshot[2a185c4e1c][Flex_P1000_96_GRIPPER_HS_TM_TC_MB_2_16_Smoke].json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is @SyntaxColoring comment I believe.
"alternateDropLocation": true, ➡️ "alternateDropLocation": false,
and then the x position value is different consistently.

y3rsh
y3rsh approved these changes Mar 16, 2024
View reviewed changes
Copy link
Collaborator

@y3rsh y3rsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a decision on the alternate tip location and then merge.

@github-actions github-actions bot force-pushed the app-testing/edge-from-edge branch 3 times, most recently from 7907674 to bc62348 Compare March 19, 2024 07:34
SyntaxColoring
SyntaxColoring approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The x-coordinate and alternation things are ticketed as AUTH-42.

Other changes are tracebacks (OK) and runTimeParameters additions (expected), so this looks good to merge.

@SyntaxColoring SyntaxColoring merged commit 6b05f46 into edge Mar 20, 2024
@SyntaxColoring SyntaxColoring deleted the app-testing/edge-from-edge branch March 20, 2024 14:05
@SyntaxColoring SyntaxColoring mentioned this pull request Mar 20, 2024
Merged
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
@github-actions @y3rsh @Carlos-fernandez
fix(app-testing): snapshot failure capture (#14586)
ca2f7d9 
This PR is an automated snapshot update request. Please review the
changes and merge if they are acceptable or find you bug and fix it.

Co-authored-by: y3rsh <[email protected]>
Carlos-fernandez pushed a commit that referenced this pull request Jun 3, 2024
@github-actions @y3rsh @Carlos-fernandez
fix(app-testing): snapshot failure capture (#14586)
84b7e77 
This PR is an automated snapshot update request. Please review the
changes and merge if they are acceptable or find you bug and fix it.

Co-authored-by: y3rsh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y3rsh y3rsh y3rsh approved these changes

@SyntaxColoring SyntaxColoring SyntaxColoring approved these changes

Assignees

@jbleon95 jbleon95

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SyntaxColoring @y3rsh @jbleon95