feat(api): add script to run threshold-finding alg on existing pressure sensor data #14549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… average for each algorythm and derivative over time
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #14549 +/- ##
==========================================
- Coverage 67.79% 67.53% -0.26%
==========================================
Files 2516 2511 -5
Lines 72117 72391 +274
Branches 9280 9280
==========================================
Hits 48889 48889
- Misses 21010 21284 +274
Partials 2218 2218
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sfoster1
requested changes
Mar 11, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
…re sensor data (#14549) This is a testing script that allows us to read in existing csv data, and use it to try out algorithms we might want to implement in firmware for detecting when a pipette tip first touches water. Afterward, we can use metadata in the provided csv to compare results with "true" height, and determine the efficacy of each one. The csv data being used here is currently an instance of `final_report.csv`, which conglomerates the time, pressure sensor output, plunger positions, and z stage positions of many individual trials of liquid probing. This addresses [EXEC-138](https://opentrons.atlassian.net/browse/EXEC-138?atlOrigin=eyJpIjoiMDQxMmVjMjI4ZGY5NGU3NDk2NDEzZjRiODEyZThjOTEiLCJwIjoiaiJ9). [EXEC-138]: https://opentrons.atlassian.net/browse/EXEC-138?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Ryan howard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a testing script that allows us to read in existing csv data, and use it to try out algorithms we might want to implement in firmware for detecting when a pipette tip first touches water. Afterward, we can use metadata in the provided csv to compare results with "true" height, and determine the efficacy of each one.
The csv data being used here is currently an instance of
final_report.csv, which conglomerates the time, pressure sensor output, plunger positions, and z stage positions of many individual trials of liquid probing.This addresses EXEC-138.