fix(app): update toggle group, overflow btn, historical protocol run colors #14532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenthagen
commented
Feb 20, 2024
| @@ -26,6 +26,7 @@ const BUTTON_GROUP_STYLES = css` | |||
| &:focus { | |||
| box-shadow: none; | |||
| color: ${COLORS.white}; | |||
| background-color: ${COLORS.blue50}; | |||
There was a problem hiding this comment.
this overrides the blue55 focus state background color that was coming from PrimaryButton
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.2.0 #14532 +/- ##
=======================================================
+ Coverage 67.76% 67.78% +0.01%
=======================================================
Files 2517 2517
Lines 72058 72114 +56
Branches 9276 9300 +24
=======================================================
+ Hits 48832 48879 +47
- Misses 21008 21014 +6
- Partials 2218 2221 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
updates to helix colors to close tickets RAUT-978, RAUT-982, RAUT-989
Test Plan
verified correct colors, updated unit tests
Changelog
Review requests
check colors of component states in tickets
Risk assessment
low