docs(api): new ProtocolContext.deck behavior for multi-slot modules
#14523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.2.0 #14523 +/- ##
====================================================
Coverage 67.79% 67.79%
====================================================
Files 2518 2518
Lines 72459 72459
Branches 9276 9276
====================================================
Hits 49123 49123
Misses 21118 21118
Partials 2218 2218
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jwwojak
reviewed
Feb 20, 2024
jwwojak
reviewed
Feb 20, 2024
sanni-t
approved these changes
Feb 21, 2024
| @@ -1085,6 +1092,9 @@ def deck(self) -> Deck: | |||
| reflect the new deck state, add a :py:meth:`.pause` or use | |||
| :py:meth:`.move_labware` instead. | |||
|
|
|||
| .. versionchanged:: 2.14 | |||
| Includes the Thermocycler in all of the slots it occupies. | |||
There was a problem hiding this comment.
Should we mention that in prior versions it returns None for those slots even when they are occupied by the thermocycler?
There was a problem hiding this comment.
Sure, I'll put that in the docstring body (to keep this directive short).
jwwojak
reviewed
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Follow up to dev work in #14491.
Test Plan
Check the sandbox.
Changelog
ProtocolContext.deckReview requests
Would like an all clear on removing the known issue. You could still get in a bad jam on 7.1.x.
Risk assessment
v low, docs