fix(api): reconfigure instrument cache after a firmware update #14502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.2.0 #14502 +/- ##
====================================================
Coverage 67.77% 67.77%
====================================================
Files 2519 2519
Lines 72017 72017
Branches 9274 9274
====================================================
Hits 48809 48809
Misses 20993 20993
Partials 2215 2215
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sfoster1
approved these changes
Feb 15, 2024
| @@ -523,6 +524,7 @@ async def update_firmware( | |||
| message="Update failed because of uncaught error", | |||
| wrapping=[PythonException(e)], | |||
| ) from e | |||
| self._configured_since_update = False | |||
There was a problem hiding this comment.
probably wants to be in a finally:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The hardware controller sets the proper motor currents for each axis when the instruments are cached. Whenever a subsystem gets rebooted/updated, the motor current setting is lost. This means we must re-configure the instrument cache after we update a firmware, to make sure the subsystem motor is set up correctly.