fix(app): ensure protocol doesn't have stale status before analysis completion

[smb2268]

fix RQA-2297

Overview

During the few seconds between when isAnalyzing is true and before the analysis has resolved, the protocol card was showing a stale protocol banner. To avoid this, we should only return a stale status if analysis != null

Test Plan

Upload a protocol, see that it no longer flashes a stale banner between the loading and completed states -- see test video here:
https://github.com/Opentrons/opentrons/assets/14302493/37059d7b-ab42-4296-80fc-f3bbe52eef88

Changelog

Add analysis != null to condition for returning a stale status

Review requests

Look over video and code

Risk assessment

Low

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (17963c0) 67.77% compared to head (e52b34c) 67.77%.

Additional details and impacted files

@@                   Coverage Diff                   @@
##           chore_release-7.2.0   #14451      +/-   ##
=======================================================
- Coverage                67.77%   67.77%   -0.01%     
=======================================================
  Files                     2518     2518              
  Lines                    71968    71968              
  Branches                  9244     9244              
=======================================================
- Hits                     48777    48776       -1     
  Misses                   20989    20989              
- Partials                  2202     2203       +1     

Flag	Coverage Δ
app	64.58% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
app/src/organisms/ProtocolsLanding/utils.ts	57.14% <0.00%> (ø)

... and 1 file with indirect coverage changes

[jerader]

changes make sense to me!