Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): deprecate Formik, migrate to React-Hook-Form #14408

Closed
wants to merge 16 commits into from

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Feb 1, 2024

closes RAUT-953

Overview

blocked until #14407 merges!

This PR deprecates the usage of Formik in PD and migrates to React-Hook-Form. Additionally, YUP is updated to the latest version.

Test Plan

Smoke test PD! In particular, mess around with editing modules, configuration (staging areas, trash, waste chute) and pipettes and adding liquids. Those areas were particularly heavy with formik

Changelog

  • refactor a bunch of components to use React-hook-form

Review requests

see test plan

Risk assessment

medium-ish, this is a big refactor and deprecates Formik which is a legacy library we have been using.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 118 lines in your changes are missing coverage. Please review.

Comparison is base (10be941) 68.24% compared to head (54f154e) 68.20%.

❗ Current head 54f154e differs from pull request most recent head 96c8263. Consider uploading reports for the commit 96c8263 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14408      +/-   ##
==========================================
- Coverage   68.24%   68.20%   -0.04%     
==========================================
  Files        1629     2513     +884     
  Lines       54896    71945   +17049     
  Branches     4132     9186    +5054     
==========================================
+ Hits        37465    49073   +11608     
- Misses      16741    20699    +3958     
- Partials      690     2173    +1483     
Flag Coverage Δ
app 64.83% <ø> (+30.12%) ⬆️
protocol-designer 37.95% <50.62%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../components/modals/CreateFileWizard/InputField.tsx 50.00% <ø> (+3.33%) ⬆️
...mponents/modals/CreateFileWizard/RobotTypeTile.tsx 100.00% <100.00%> (ø)
...omponents/modals/EditModulesModal/SlotDropdown.tsx 100.00% <100.00%> (ø)
...col-designer/src/components/modules/TrashModal.tsx 96.66% <100.00%> (+0.11%) ⬆️
protocol-designer/src/constants.ts 97.95% <ø> (ø)
...onents/modals/CreateFileWizard/PipetteTipsTile.tsx 86.79% <93.33%> (+0.51%) ⬆️
...onents/modals/CreateFileWizard/PipetteTypeTile.tsx 85.71% <88.88%> (+0.42%) ⬆️
...nents/modals/EditModulesModal/ConnectedSlotMap.tsx 33.33% <0.00%> (+13.33%) ⬆️
...mponents/modals/EditModulesModal/ModelDropdown.tsx 75.00% <50.00%> (-5.00%) ⬇️
...omponents/modals/CreateFileWizard/MetadataTile.tsx 83.33% <71.42%> (-16.67%) ⬇️
... and 12 more

... and 909 files with indirect coverage changes

@jerader jerader closed this Feb 1, 2024
@jerader jerader deleted the pd_migrate-away-from-formik branch February 1, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants