Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): build-ts before push to npm #14357

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Conversation

y3rsh
Copy link
Collaborator

@y3rsh y3rsh commented Jan 26, 2024

Overview

There is no typing present in 0.1.1 of

Test Plan

If this is the correct fix, merge it then tag - or - tag this branch? to test a new deploy.

Changelog

  • add make build-ts in the GitHub Actions job that publishes for shared-data
  • add make build-ts in the GitHub Actions job that publishes for components

Review requests

Risk assessment

None to any functional code. CI only change to build types before distributing components and shared-data.

@y3rsh y3rsh requested a review from b-cooper January 26, 2024 12:39
@y3rsh y3rsh self-assigned this Jan 26, 2024
@y3rsh y3rsh requested a review from a team as a code owner January 26, 2024 12:39
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4371e79) 68.11% compared to head (38a3ffc) 68.07%.
Report is 5 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14357      +/-   ##
==========================================
- Coverage   68.11%   68.07%   -0.05%     
==========================================
  Files        2503     2503              
  Lines       71587    71702     +115     
  Branches     9111     9145      +34     
==========================================
+ Hits        48764    48808      +44     
- Misses      20695    20763      +68     
- Partials     2128     2131       +3     
Flag Coverage Δ
app 65.61% <ø> (+<0.01%) ⬆️
components 48.85% <ø> (ø)
protocol-designer 35.21% <ø> (-0.09%) ⬇️
shared-data 75.25% <ø> (ø)
step-generation 86.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@y3rsh
Copy link
Collaborator Author

y3rsh commented Jan 26, 2024

Progress

On build 0.1.2-alpha.0 components types are working.
shared-data they are not.

BUT If I copy in the the contents of shared-data/lib/js from my local build of the monorepo, into node_modules, which is where the package.json says types will be, then shared-data works fine.

  • Need to figure out why in ci shared-data/lib/js is not present.

Copy link
Contributor

@b-cooper b-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@b-cooper b-cooper merged commit 88de889 into edge Jan 29, 2024
51 checks passed
ncdiehl11 pushed a commit that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants