fix(api): use move flags in aionotify for modules #14345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After updating openembedded and buildroot, their udevs will actually create temporary files for module serial port symlinks and then rename the tempfiles to the real thing. This wouldn't get noticed because they were moves, rather than creates or deletes. Getting aionotify to tell us about moves too and plumbing those events through the add/delete paths fixes the issue. Closes RQA-2240
vegano1
approved these changes
Jan 24, 2024
ncdiehl11
pushed a commit
that referenced
this pull request
Feb 1, 2024
After updating openembedded and buildroot, their udevs will actually create temporary files for module serial port symlinks and then rename the tempfiles to the real thing. This wouldn't get noticed because they were moves, rather than creates or deletes. Getting aionotify to tell us about moves too and plumbing those events through the add/delete paths fixes the issue. Closes RQA-2240
sanni-t
added a commit
that referenced
this pull request
May 8, 2024
) Closes AUTH-379 # Overview #14345 updated the module ports filtering to exclude any temporary ports created by udev. But the regex used for port name matching filters out only Flex port names (e.g. `ot_module_thermocycler2.tmp-c166:2`). This PR adds regex to filter out OT-2 temp ports as well (e.g. `.#ot_module_thermocycler0b494617b5e4f08ae`). # Risk assessment Medium. Can affect module connectivity but is easy to test and rule out any issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating openembedded and buildroot, their udevs will actually create temporary files for module serial port symlinks and then rename the tempfiles to the real thing. This wouldn't get noticed because they were moves, rather than creates or deletes. Getting aionotify to tell us about moves too and plumbing those events through the add/delete paths fixes the issue.
Closes RQA-2240