Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate Analyses Snapshot Update edge #14310

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Evaluate Analyses Snapshot Update edge #14310

merged 1 commit into from
Jan 11, 2024

Conversation

github-actions[bot]
Copy link
Contributor

This PR is an automated snapshot update request. Please review the changes and merge if they are acceptable or find you bug and fix it.

@github-actions github-actions bot requested a review from a team as a code owner January 11, 2024 07:09
@SyntaxColoring
Copy link
Contributor

Most of these are just traceback changes, which look fine to me.

@jbleon95 Can you take a look at app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[25f79fd65e][Flex_None_None_TM_2_16_AnalysisError_ModuleInStagingAreaCol3].json and confirm that it's expected, given #14287?

@SyntaxColoring SyntaxColoring assigned jbleon95 and unassigned jbleon95 Jan 11, 2024
jbleon95
jbleon95 approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@jbleon95 jbleon95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error in snapshot 25f79fd65e is expected with the changes made and is now correctly failing. Everything else is just line number changes and looks fine.

@jbleon95 jbleon95 merged commit 8354e7f into edge Jan 11, 2024
@jbleon95 jbleon95 deleted the app-testing/edge-from-edge branch January 11, 2024 20:18
mjhuff pushed a commit that referenced this pull request Jan 23, 2024
@github-actions @y3rsh
fix(app-testing): snapshot failure capture (#14310)
c871c73 
Co-authored-by: y3rsh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbleon95 jbleon95 jbleon95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SyntaxColoring @jbleon95 @y3rsh