Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(protocol-library-kludge): remove deprecated protocol library ui #14298

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

b-cooper
Copy link
Contributor

@b-cooper b-cooper commented Jan 8, 2024

Remove unused and unlinked react app-let that was iframed into the old protocol library ui.

@b-cooper b-cooper requested review from shlokamin and a team January 8, 2024 18:45
@b-cooper b-cooper requested a review from a team as a code owner January 8, 2024 18:45
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1e10a79) 68.25% compared to head (046d3e8) 68.21%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14298      +/-   ##
==========================================
- Coverage   68.25%   68.21%   -0.04%     
==========================================
  Files        1629     2520     +891     
  Lines       54889    71905   +17016     
  Branches     4125     9181    +5056     
==========================================
+ Hits        37465    49051   +11586     
- Misses      16735    20681    +3946     
- Partials      689     2173    +1484     
Flag Coverage Δ
app 64.81% <ø> (+30.05%) ⬆️
components 49.38% <ø> (ø)
labware-library 41.10% <ø> (ø)
protocol-designer 38.01% <ø> (ø)
react-api-client 66.16% <ø> (ø)
step-generation 86.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 891 files with indirect coverage changes

Copy link
Contributor

@brenthagen brenthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

Copy link
Member

@shlokamin shlokamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@b-cooper b-cooper merged commit 5cdcac7 into edge Feb 1, 2024
54 checks passed
@b-cooper b-cooper deleted the remove-protocol-library-kludge branch February 1, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants