Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not try and set acls in docs and labware #14290

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

sfoster1
Copy link
Member

@sfoster1 sfoster1 commented Jan 5, 2024

Matches new aws-side settings.

@sfoster1 sfoster1 requested a review from a team as a code owner January 5, 2024 15:35
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3352003) 68.09% compared to head (1cc047f) 68.09%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #14290   +/-   ##
=======================================
  Coverage   68.09%   68.09%           
=======================================
  Files        2508     2508           
  Lines       71440    71440           
  Branches     9058     9058           
=======================================
  Hits        48646    48646           
  Misses      20687    20687           
  Partials     2107     2107           
Flag Coverage Δ
labware-library 41.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ecormany
Copy link
Contributor

ecormany commented Jan 5, 2024

Looks like API docs build passed on the latest push to this branch, huzzah.

@sfoster1 sfoster1 merged commit a5c6458 into edge Jan 5, 2024
14 checks passed
@sfoster1 sfoster1 deleted the no-acls-in-docs-lablib-deploys branch January 5, 2024 17:41
mjhuff pushed a commit that referenced this pull request Jan 23, 2024
* chore: do not try and set acls in docs and labware

* trigger ll sandbox deploys on action changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants