feat(notify-server): Delete notify-server

[SyntaxColoring]

Overview

This deletes the notify-server project.

Years ago, we added notify-server because we thought it would be helpful for getting the robot to provide realtime notifications to clients. However, shifting priorities meant that it never developed beyond a proof-of-concept. It let you listen for door-opened/door-closed events, but that's it.

Realtime notifications are getting renewed interest, but we no longer think notify-server is the way to do them.

Deleting the project saves some CI time and relieves us from maintaining its dependencies.

This PR has an OT-2 Buildroot co-dependency: Opentrons/buildroot#215

Test Plan

Grab images from the build server (ot2-system.zip/system-update.zip) and push them to an OT-2 and Flex. Make sure robot-server still starts, and journalctl doesn't show any systemd errors complaining about a missing unit or anything like that.

Changelog

The user-facing changes entailed by deleting this project are:

• Remove the /notifications/subscribe WebSocket endpoint. As far as I can tell, it was not publicly documented.
• Remove the notify_server package and script from the robot. These were described in notify-server/README.rst, but otherwise not advertised, as far as I can tell.

There is currently no replacement for these removals, although we are planning one. Meanwhile, I recommend simply polling GET /robot/door/status.

Review requests

If anyone has reason to believe that anyone cares about these features, speak now or forever fold your pizza.

Risk assessment

Very low, assuming no one cares about these features.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd7ddee) 68.24% compared to head (61cd751) 68.23%.
Report is 1 commits behind head on edge.

Additional details and impacted files

@@            Coverage Diff             @@
##             edge   #14280      +/-   ##
==========================================
- Coverage   68.24%   68.23%   -0.02%     
==========================================
  Files        2512     2512              
  Lines       71877    71868       -9     
  Branches     9175     9175              
==========================================
- Hits        49055    49041      -14     
- Misses      20656    20661       +5     
  Partials     2166     2166              

Flag	Coverage Δ
app	64.83% <ø> (ø)
components	49.62% <ø> (ø)
g-code-testing	96.48% <ø> (ø)
hardware	57.23% <ø> (-0.06%)	⬇️
hardware-testing	∅ <ø> (∅)
shared-data	75.25% <ø> (ø)
system-server	96.04% <ø> (ø)
update-server	63.58% <ø> (ø)
usb-bridge	76.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
robot-server/robot_server/hardware.py	78.33% <ø> (-2.83%)	⬇️
robot-server/robot_server/router.py	100.00% <ø> (ø)

... and 2 files with indirect coverage changes

[sanni-t]

This looks good and shouldn't affect robot operations but still we should check on robots (esp the systemd notifications part). I can do an OT2 test if you haven't already.

[SyntaxColoring]

I’m seeing robot server startup failures. I think they’re related to the general dependency upgrades, outside of this PR, but we should hold off on merging until that’s confirmed.