refactor(app): verify probe presence before pipette calibration and labware position check #14126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.1.0 #14126 +/- ##
=======================================================
+ Coverage 70.44% 70.46% +0.02%
=======================================================
Files 2483 2512 +29
Lines 70328 71198 +870
Branches 8770 8963 +193
=======================================================
+ Hits 49542 50172 +630
- Misses 18635 18837 +202
- Partials 2151 2189 +38
Flags with carried forward coverage won't be shown. Click here to find out more.
|
smb2268
reviewed
Dec 7, 2023
| mount: mount, | ||
| }, | ||
| }, | ||
| ] | ||
| setIsPending(true) | ||
| refetch() |
There was a problem hiding this comment.
I added this refetch in so that we would have the most up to date attachedInstrument state to check for the tip. Is that still necessary? Looks like it could be removed.
The nesting of the promises was on purpose to get the right error screen to display so reintroduce it, but it works slightly differently now because we also don't need the instruments query anymore since we were just using that to get the tip status. Also add the failure screen to the module calibration
|
The nesting definitely ended up being needed but @smb2268 you're right the instruments query was not, so ditched that. Tested on a robot. |
smb2268
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The app now checks for probe presence for pipette before performing pipette calibration and labware position check.