feat(api): add get tip presence command in protocol engine #14095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.1.0 #14095 +/- ##
=======================================================
- Coverage 70.44% 70.43% -0.01%
=======================================================
Files 2483 2512 +29
Lines 70327 71289 +962
Branches 8767 8996 +229
=======================================================
+ Hits 49539 50215 +676
- Misses 18637 18872 +235
- Partials 2151 2202 +51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sfoster1
requested changes
Dec 5, 2023
| pipette_id = params.pipetteId | ||
| expected_state = params.expectedState | ||
|
|
||
| result = await self._tip_handler.verify_tip_presence( |
There was a problem hiding this comment.
I think I'd expect this to raise, because the only reason that I would call this instead of get tip presence is to simplify a status check that should fail.
sfoster1
approved these changes
Dec 5, 2023
ahiuchingau
force-pushed
the
api_check-tip-presence-in-protocol-engine
branch
from
bb43975
to
241f9cd
Compare
format typo add command to schema 8 made prettier add get tip presence to shared-data add more tests
ahiuchingau
force-pushed
the
api_check-tip-presence-in-protocol-engine
branch
from
241f9cd
to
86f5ab6
Compare
ahiuchingau
requested review from
TamarZanzouri
and removed request for
a team
sfoster1
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds the
get_tip_presencecommand in protocol engine so we can actually get the realtime tip presence response from the pipette, instead of having to rely on the instrument endpoint which only returns the cached tip detected value.Closes RQA-1992