Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): render protocol setup labware addressableAreaName location #14013

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

brenthagen
Copy link
Contributor

Overview

in ODD/desktop protocol setup labware lists, renders labware location referenced by addressableAreaName

Screen Shot 2023-11-16 at 4 58 41 PM

Test Plan

visually verified staging area slot location rendering

Changelog

  • Renders protocol setup labware addressableAreaName location

Review requests

Risk assessment

low

@brenthagen brenthagen requested a review from a team as a code owner November 16, 2023 22:01
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #14013 (da3d96c) into edge (09d48ce) will decrease coverage by 0.04%.
Report is 5 commits behind head on edge.
The diff coverage is 16.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14013      +/-   ##
==========================================
- Coverage   70.68%   70.64%   -0.04%     
==========================================
  Files        1628     2506     +878     
  Lines       54245    70938   +16693     
  Branches     3858     8783    +4925     
==========================================
+ Hits        38342    50115   +11773     
- Misses      15236    18665    +3429     
- Partials      667     2158    +1491     
Flag Coverage Δ
app 67.64% <16.66%> (+29.08%) ⬆️
react-api-client 65.87% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...vices/ProtocolRun/SetupLabware/LabwareListItem.tsx 71.76% <33.33%> (ø)
app/src/organisms/ProtocolSetupLabware/index.tsx 49.28% <0.00%> (ø)

... and 879 files with indirect coverage changes

Copy link
Contributor

@b-cooper b-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@b-cooper b-cooper requested a review from a team as a code owner November 16, 2023 22:28
@b-cooper b-cooper merged commit 59b8713 into edge Nov 16, 2023
22 of 23 checks passed
@b-cooper b-cooper deleted the app_render-labware-addressable-area-name branch November 16, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants