Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): only show ODD runs loading screen when server returns 503 #13940

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

shlokamin
Copy link
Member

Overview

We currently show a loading screen on the ODD when the runs endpoint returns any error. We specifically want to only show the loading screen when the endpoint returns a 503.

Partially addresses https://opentrons.atlassian.net/browse/RQA-1872

Risk assessment

Low

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #13940 (623a304) into edge (d826bfb) will increase coverage by 0.00%.
The diff coverage is 75.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #13940   +/-   ##
=======================================
  Coverage   70.66%   70.66%           
=======================================
  Files        2508     2508           
  Lines       70726    70728    +2     
  Branches     8681     8681           
=======================================
+ Hits        49977    49979    +2     
  Misses      18626    18626           
  Partials     2123     2123           
Flag Coverage Δ
app 68.08% <0.00%> (ø)
react-api-client 65.96% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
react-api-client/src/runs/useAllRunsQuery.ts 91.66% <100.00%> (+1.66%) ⬆️
...src/pages/OnDeviceDisplay/RobotDashboard/index.tsx 68.42% <0.00%> (ø)

@shlokamin shlokamin merged commit d4547e6 into edge Nov 8, 2023
23 checks passed
@shlokamin shlokamin deleted the app_odd-only-show-initializing-screen-when-503 branch November 8, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants