Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): ODD LPC copy and styling #13925

Merged
merged 5 commits into from
Nov 8, 2023
Merged

fix(app): ODD LPC copy and styling #13925

merged 5 commits into from
Nov 8, 2023

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Nov 6, 2023

closes RQA-1052
closes RQA-1353
closes RQA-1358

Overview

This PR address several ODD LPC copy and formatting bugs, including incorrect text for PrepareSpace steps, button misalignment in TipConfirmation steps, and incorrect formatting in the ExitConfirmation step.

Test Plan

  • check all implicated LPC steps on ODD

Changelog

  • add new copy specific to ODD for clearing deck space in PrepareSpace steps
  • conditionally render to place modules on the deck if modules are in protocol and LPC is on the first step
  • justify TipConfirmation buttons to Flex end
  • re-style ExitConfirmation specific to ODD designs

Review requests

general

Risk assessment

low

Fix copy for preparing space conditional on step index and module presence. Correctly style
ExitConfirmation step. Fix button alignment in TipConfirmation.
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner November 6, 2023 20:05
@ncdiehl11 ncdiehl11 requested review from mjhuff and removed request for a team November 6, 2023 20:05
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #13925 (bad4a60) into edge (c15d30e) will decrease coverage by 0.30%.
Report is 30 commits behind head on edge.
The diff coverage is 60.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #13925      +/-   ##
==========================================
- Coverage   70.75%   70.46%   -0.30%     
==========================================
  Files        1629     2507     +878     
  Lines       54062    70931   +16869     
  Branches     3797     8710    +4913     
==========================================
+ Hits        38254    49981   +11727     
- Misses      15143    18831    +3688     
- Partials      665     2119    +1454     
Flag Coverage Δ
app 67.44% <60.00%> (+23.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...p/src/organisms/LabwarePositionCheck/PickUpTip.tsx 61.19% <100.00%> (ø)
...p/src/organisms/LabwarePositionCheck/ReturnTip.tsx 64.28% <100.00%> (ø)
...organisms/LabwarePositionCheck/TipConfirmation.tsx 80.00% <ø> (ø)
...p/src/organisms/LabwarePositionCheck/CheckItem.tsx 73.41% <0.00%> (ø)
...rganisms/LabwarePositionCheck/ExitConfirmation.tsx 80.00% <66.66%> (ø)
...arePositionCheck/LabwarePositionCheckComponent.tsx 2.88% <0.00%> (ø)

... and 882 files with indirect coverage changes

@mjhuff mjhuff requested a review from a team November 6, 2023 21:35
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small nits, but it's looking good! Feel free to merge after making the changes + passing CI 🚀

@ncdiehl11 ncdiehl11 merged commit 2655f2b into edge Nov 8, 2023
21 of 22 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_app-odd-lpc-copy branch November 8, 2023 20:47
ncdiehl11 added a commit that referenced this pull request Nov 14, 2023
closes RQA-1052
closes RQA-1353
closes RQA-1358

Fix copy for preparing space conditional on step index and module presence. Correctly style
ExitConfirmation step. Fix button alignment in TipConfirmation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants