feat(step-generation, shared-data): add waste chute commands to types & atomic commands #13916
Conversation
…and types & atommic commands closes RAUT-849
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13916 +/- ##
==========================================
- Coverage 70.84% 70.73% -0.12%
==========================================
Files 2504 1631 -873
Lines 70452 54112 -16340
Branches 8609 3815 -4794
==========================================
- Hits 49913 38275 -11638
+ Misses 18441 15163 -3278
+ Partials 2098 674 -1424
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| // TODO(jr, 11/6/23): add to result type | ||
| result?: {} |
There was a problem hiding this comment.
Do we know what the result type should be?
There was a problem hiding this comment.
I don't think we do yet, so a TODO is fine for now
| ) => { | ||
| const { pipetteId, addressableAreaName } = args | ||
|
|
||
| // No-op if there is no pipette |
There was a problem hiding this comment.
is this consistent with what we'd do elsewhere in SG? It seems to me like we'd probably create an error?
| CurriedCommandCreator, | ||
| } from '../types' | ||
|
|
||
| export type WasteChuteCommandsTypes = 'dispense' | 'blow out' | 'drop tip' |
There was a problem hiding this comment.
the spaces in this internal enumeration seem inconsistent with the rest of our codebase, is there are reason they're not camelCase?
There was a problem hiding this comment.
it was so i could plug them into the error creator, but ya i should change these to camelCase then split up the strings for the error creator in another const.
closes RAUT-849 and RAUT-766
Overview
This PR lays the ground work for wiring up the waste chute commands in Step-generation.
moveToAddressableAreacommand type to schemaV8 commands, as well asdispenseInPlacemoveToAddressableArea,dispenseInPlace,dropTipInPlace, andblowoutInPlacewasteChuteCommandsUtilnothing is wired up yet!
Test Plan
Nothing is wired up so just look through the types and the step-generation atomic commands and make sure things look right and the params match.
See here for params: https://opentrons.atlassian.net/wiki/spaces/RPDO/pages/3862200335/Deck+Configuration+Addressable+Areas+PE+Command+Shapes
Changelog
moveToAddressableArea,dispenseInPlace,dropTipInPlace, andblowoutInPlace) and write testswasteChuteCommandsUtilutil and write testaddtionalEquipmentDoesNotExistReview requests
see test plan
Risk assessment
low