Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hardware-testing): Improvements to daily-setup process after more testing #13899

Merged
merged 33 commits into from
Nov 8, 2023

Conversation

andySigler
Copy link
Contributor

Overview

Improvements made to daily-setup:

  • Push plotly JS source to robot, so it can be loaded from robot server instead of internet
  • Fixes bug in graph webpage where the on-error timeout wasn't being cleared when new data was received
  • Option to skip stability and/or accuracy checks
  • Improved colors on status bar during setup process

In addition, this PR adds a simple "pre-heat" option to the gravimetric tests (off by default). If enabled using the --pre-heat argument, then immediately after homing the plunger will move up/down slowly to raise the temperature. The process will exit if any of the below are true:

  • 10 minutes has elapsed
  • the pipette temperature is >= 28C
  • the pipette temperature is >= the starting temperature plus 3C

Test Plan

Changelog

Review requests

Risk assessment

@andySigler andySigler requested review from a team as code owners November 2, 2023 01:28
@andySigler andySigler requested review from TamarZanzouri, ryanthecoder and a team and removed request for a team November 2, 2023 01:28
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #13899 (3ff24dc) into edge (5dc8819) will decrease coverage by 0.04%.
Report is 36 commits behind head on edge.
The diff coverage is n/a.

❗ Current head 3ff24dc differs from pull request most recent head 812182a. Consider uploading reports for the commit 812182a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #13899      +/-   ##
==========================================
- Coverage   70.86%   70.82%   -0.04%     
==========================================
  Files        2501     2499       -2     
  Lines       70340    70136     -204     
  Branches     8600     8585      -15     
==========================================
- Hits        49845    49673     -172     
+ Misses      18399    18377      -22     
+ Partials     2096     2086      -10     
Flag Coverage Δ
hardware-testing ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

@andySigler andySigler merged commit 43077cd into edge Nov 8, 2023
7 checks passed
@andySigler andySigler deleted the test-sz-411-pipettes branch November 8, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants