Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(protocol-designer, labware-library): remove unused full story integration #13892

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

b-cooper
Copy link
Contributor

@b-cooper b-cooper commented Nov 1, 2023

Overview

Remove unused analytics tool and support code.

Closes RAUT-76

Risk assessment

low

@b-cooper b-cooper requested review from shlokamin, jerader and a team November 1, 2023 20:15
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #13892 (60ce60c) into edge (754cbcf) will increase coverage by 0.11%.
Report is 4 commits behind head on edge.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #13892      +/-   ##
==========================================
+ Coverage   70.86%   70.98%   +0.11%     
==========================================
  Files        2501     2498       -3     
  Lines       70343    70203     -140     
  Branches     8601     8574      -27     
==========================================
- Hits        49848    49831      -17     
+ Misses      18398    18275     -123     
  Partials     2097     2097              
Flag Coverage Δ
labware-library 51.50% <ø> (+2.32%) ⬆️
protocol-designer 45.70% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
labware-library/src/analytics/index.ts 20.00% <ø> (+3.33%) ⬆️
labware-library/src/analytics/utils.ts 25.92% <ø> (+1.78%) ⬆️
protocol-designer/src/analytics/actions.ts 55.55% <ø> (+10.10%) ⬆️
...designer/src/components/modals/GateModal/index.tsx 0.00% <ø> (ø)
protocol-designer/src/initialize.ts 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@shlokamin shlokamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@b-cooper b-cooper merged commit 4c97e43 into edge Nov 9, 2023
32 of 33 checks passed
@b-cooper b-cooper deleted the chore_remove-fullstory branch November 9, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants