Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): invalidate OT2 calibration queries when calibration flows complete #13809

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

b-cooper
Copy link
Contributor

Overview

Ensure that all queries for /calibration endpoints (OT2 only) are invalidated upon completion of any of the three OT2 calibration flows.

Closes RQA-1814

Review requests

  • Run TLC from the Setup Screen of the OT2 protocol setup flow. The tip rack item should update to green upon completion.

Risk assessment

low

…omplete

Ensure that all queries for /calibration endpoints (OT2 only) are invalidated upon completion of any
of the three OT2 calibration flows.

Closes RQA-1814
@b-cooper b-cooper requested a review from a team as a code owner October 18, 2023 16:31
@b-cooper b-cooper requested review from smb2268, nusrat813 and rwarshauer and removed request for a team October 18, 2023 16:31
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #13809 (c71be46) into chore_release-7.0.1 (295908b) will decrease coverage by 0.03%.
Report is 1 commits behind head on chore_release-7.0.1.
The diff coverage is 61.11%.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.0.1   #13809      +/-   ##
=======================================================
- Coverage                71.25%   71.22%   -0.03%     
=======================================================
  Files                     1589     2432     +843     
  Lines                    52767    68444   +15677     
  Branches                  3453     8057    +4604     
=======================================================
+ Hits                     37598    48751   +11153     
- Misses                   14634    17801    +3167     
- Partials                   535     1892    +1357     
Flag Coverage Δ
app 68.80% <75.00%> (+25.23%) ⬆️
components 60.61% <33.33%> (-0.12%) ⬇️
labware-library 49.17% <ø> (ø)
protocol-designer 46.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...mponents/src/testing/utils/renderWithProviders.tsx 81.81% <100.00%> (+1.81%) ⬆️
app/src/organisms/CalibrateDeck/index.tsx 77.14% <75.00%> (ø)
app/src/organisms/CalibratePipetteOffset/index.tsx 63.63% <75.00%> (ø)
app/src/organisms/CalibrateTipLength/index.tsx 74.28% <75.00%> (ø)
...omponents/src/testing/utils/mountWithProviders.tsx 0.00% <0.00%> (ø)
components/src/testing/utils/mountWithStore.tsx 0.00% <0.00%> (ø)

... and 840 files with indirect coverage changes

@b-cooper b-cooper merged commit 692888c into chore_release-7.0.1 Oct 18, 2023
43 of 44 checks passed
@b-cooper b-cooper deleted the app_fix-tlc-cache-bust branch October 18, 2023 18:41
y3rsh added a commit that referenced this pull request Oct 25, 2023
* edge: (77 commits)
  fix(app): update move gantry text in change pipette flow (#13712)
  fix(app): fix CI after release merge back (#13816)
  chore(hardware): add opentrons hardware package to ot 2 build (#13770)
  feat(protocol-designer): correct step count in create file wizard (#13807)
  feat(protocol-designer): error handling in create file wizard (#13804)
  fix(app): invalidate OT2 calibration queries when calibration flows complete (#13809)
  always jog (#13806)
  chore(app): point updates at dns not s3 (#13798)
  docs(api): updated Flex default flow rates (#13796)
  fix(api): Flag pipette as not ready to aspirate after pushing out air (#13728)
  fix(api, hardware): allow OT3Controller to disable tip motors (#13805)
  more blank trials; longer scale stabilize wait; submerge 2.5mm (#13788)
  fix(app): unload adapters after checking position of labware on adapter on heater shaker module (#13803)
  feat(app): wire up location conflict modal for ODD (#13797)
  feat(app): add Deck configuration page component (#13784)
  fix(robot-server): add default to robot serial (#13802)
  feat(protocol-designer, components): prep work for deck config in PD (#13775)
  feat(app, protocol-designer): plug in waste chute asset (#13800)
  fix(app): do not check mag block in calibration status (#13799)
  feat(protocol-designer): edit additional items staging area support (#13752)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants