feat(app): use metal probe for LPC on Opentrons Flex #13706
Merged
+88
−188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support the 96 channel pipette in Labware Position Check, in addition to increasing the accuracy of labware offsets, performing Labware Position Check on an Opentrons Flex will walk the user through attaching the calibration probe to the back left most nozzle and in order to use it as a visual indicator within each position check. Note: the OT2 will still "pick up a tip" to use as a visual indicator when performing LPC. Closes RAUT-711
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13706 +/- ##
==========================================
+ Coverage 70.90% 70.94% +0.04%
==========================================
Files 1604 2451 +847
Lines 53275 68850 +15575
Branches 3634 8205 +4571
==========================================
+ Hits 37773 48846 +11073
- Misses 14916 18071 +3155
- Partials 586 1933 +1347
Flags with carried forward coverage won't be shown. Click here to find out more.
|
b-cooper
requested review from
mjhuff,
shlokamin and
a team
and removed request for
a team and
mjhuff
jerader
reviewed
Oct 5, 2023
Comment on lines
+138
to
+145
| <MenuItem | ||
| onClick={handleClickSendToOT3} | ||
| data-testid="ProtocolOverflowMenu_sendToOT3" | ||
| > | ||
| {t('protocol_list:send_to_robot_overflow', { | ||
| robot_display_name: FLEX_DISPLAY_NAME, | ||
| })} | ||
| </MenuItem> |
There was a problem hiding this comment.
shouldn't this menu item be visible only for a flex protocol?
There was a problem hiding this comment.
Just in case there is a problem with app side analysis (which would prevent us from parsing a robotType), we're allowing all protocols to be sent to the Flex (the slideout will only list available Flexes)
shlokamin
reviewed
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In order to support the 96 channel pipette in Labware Position Check, in addition to increasing the
accuracy of labware offsets, performing Labware Position Check on an Opentrons Flex will walk the
user through attaching the calibration probe to the back left most nozzle and in order to use it as
a visual indicator within each position check. Note: the OT2 will still "pick up a tip" to use as a
visual indicator when performing LPC.
Closes RAUT-711
Review requests
Risk assessment
medium