Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): sort current offsets by date to ensure order #13563

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Sep 15, 2023

closes RAUT-722 and RQA-1608

Overview

The data fetched from the runQuery hook does guarantee that the current offsets return in the same order. To fix this, I added sorting via createdAt from the offsets key

Test Plan

see the ticket attached, basically run LPC on desktop with offsets already in the table. Make sure they don't reorder during LPC. The reordering starts after the initial page of the LPC flow and ends when you complete LPC

Changelog

added sorting of the current offsets

Review requests

see test plan

Risk assessment

low

@jerader jerader requested a review from a team as a code owner September 15, 2023 17:35
@jerader jerader requested review from koji, sanni-t, ncdiehl11 and a team and removed request for a team September 15, 2023 17:35
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #13563 (de81c1c) into chore_release-7.0.0 (7003e62) will decrease coverage by 0.01%.
Report is 5 commits behind head on chore_release-7.0.0.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.0.0   #13563      +/-   ##
=======================================================
- Coverage                71.31%   71.30%   -0.01%     
=======================================================
  Files                     2419     2419              
  Lines                    68091    68140      +49     
  Branches                  7912     7939      +27     
=======================================================
+ Hits                     48558    48587      +29     
- Misses                   17680    17694      +14     
- Partials                  1853     1859       +6     
Flag Coverage Δ
app 68.90% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...es/ProtocolRun/SetupLabwarePositionCheck/index.tsx 65.21% <0.00%> (-13.73%) ⬇️

... and 4 files with indirect coverage changes

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on robot, looks good to me!

@jerader jerader merged commit 10d745b into chore_release-7.0.0 Sep 15, 2023
21 of 22 checks passed
@jerader jerader deleted the app_fix-current-offsets branch September 15, 2023 18:38
@koji
Copy link
Contributor

koji commented Sep 15, 2023

Maybe create a sort function for this?
Not recommend to overwrite the data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants