refactor(app, app-shell-odd): update configuration translation #13503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently when running
make -C app dev-odd
you see thewelcome to your opentrons flex
pop up. This is because the makefile specifies the unfinished unboxing flow route to'/dashboard'
What we want, really, is to set it tonull
, which indicates that the unboxing flow has been completed and we don't need any specific redirect.The problem is that the make commands are run in the OS shell environment, not in a JS environment. This means there is no way to convey core JS data types like
null
. So, what i did for the dev odd target was pass in "0" as the unfinished unboxing flow route, and i have the selector that grabs app configs explicitly check for string "0" and convert it tonull
.Don't love this, so if anyone has some cleaner way to go about it I'm all ears
Review requests
Run the
dev-odd
make command and make sure thewelcome to your opentrons flex
pop up does not show up