-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hardware): allow variable number of tip presence messages #13478
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13478 +/- ##
==========================================
- Coverage 71.30% 71.30% -0.01%
==========================================
Files 2419 2419
Lines 67951 67965 +14
Branches 7912 7913 +1
==========================================
+ Hits 48454 48462 +8
- Misses 17641 17647 +6
Partials 1856 1856
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, though I would like to change the name of the backend argument - I feel like ideally it's just the hardware controller that knows about the 96
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should still not be checking tip presence for the 96 chan until we implement the motor routine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit otherwise looks good to me!
6492213
to
ba71f4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good once @Laura-Danielle 's changes are addressed, some nitpicks/improvements
b23af58
to
3f9c633
Compare
3f9c633
to
388d6b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more small changes, only really important one is the error code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice! Looks good to me if tests pass.
change requests addressed
Overview
Currently, the hardware controller is only able to process one tip presence notification. This changes
tip_presence.py
to wait for and return either 1 or 2 notifications, as aList[int]
rather than anint
.At the hardware controller level, we check that both responses are the same, and then handle the tip presence status as a single value.