Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Production qc ot3 overnight test #13211

Merged
merged 20 commits into from
Aug 2, 2023
Merged

Production qc ot3 overnight test #13211

merged 20 commits into from
Aug 2, 2023

Conversation

djgomez-opentrons
Copy link
Contributor

Overview

Adds a stress test to the production QC testing suite.

Test Plan

Tested on DVT robot in BK

djgomez-opentrons and others added 17 commits July 26, 2023 12:18
@djgomez-opentrons
overnight test copied in
1ce3872
@djgomez-opentrons
edited make file, changed arguments to allow simulations, starting to…
ae4f06a 
… edit OT3Axis type change
@djgomez-opentrons
fixed axis type issue, enforce pipette attach check
669fbc4
@djgomez-opentrons
commenting out enforce pipette check
d6057ff
@djgomez-opentrons
updates to data logging
90fdf56
@djgomez-opentrons
improved logging to average error of movement points
a83b2fb
@djgomez-opentrons
updated default cycles, gantry load resets to default before final cy…
e657438 
…cles
@djgomez-opentrons
formatting and linting
21bd60c
@djgomez-opentrons
fixed bug where wrong mount was being used
9687497
@djgomez-opentrons
fixing another z axis mount bug
51edf34
@djgomez-opentrons
added a test fail or pass indication at the end
c7e8f3a
@andySigler
load defaults values from api
82ea9e8
@andySigler
fix merge conflicts; rename script
ea07b78
@andySigler
read in serial from eeprom
7174d7f
@djgomez-opentrons
exiting test if failed
9982ae0
@djgomez-opentrons
cycles to 20
e5ba48c
@djgomez-opentrons
changed order of tests, added current logging
5c6fda9
@djgomez-opentrons djgomez-opentrons requested review from a team as code owners August 1, 2023 19:35
andySigler
andySigler approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@andySigler andySigler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we ran it together and tested out different scenarios of it stalling and failing. If we are good with the number of cycles we default to, then it's good to go

@djgomez-opentrons djgomez-opentrons merged commit eab0646 into edge Aug 2, 2023
6 checks passed
@djgomez-opentrons djgomez-opentrons deleted the production_qc_ot3_overnight_test branch August 2, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andySigler andySigler andySigler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djgomez-opentrons @andySigler